Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Chunk payid demos #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Chunk payid demos #51

wants to merge 3 commits into from

Conversation

rmurphy23
Copy link

High Level Overview of Change

  • Chunking the Java PayID demo in 3 separate files one resolving on the BTC Network, on resolving on XRPL, and one resolving all PayID's belonging to Alice.
  • Chunking the NodeJS PayID demo in 3 separate files one resolving on the BTC Network, on resolving on XRPL, and one resolving all PayID's belonging to Alice.
  • Chunking the Swift PayID demo in 3 separate files one resolving on the BTC Network, on resolving on XRPL, and one resolving all PayID's belonging to Alice.

Context of Change

This change was a simple refactor. It was necessary because if a user going through this demo did not not have a PayID associated with both the XRPL and BTC networks the demo would result in a fatal error. This refactor allows users to demo the PayID resolve according to the networks for which their PayID is associated.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [** ] Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Before / After

Before the refactor there was one file for each of the PayID demos according to their respective language NodeJS, Java, and Swift. After there is three files for each PayID demo according to their respective languages.

Test Plan

Using VS Code I was able to test the NodeJS refactored demos and Java (Maven) refactored demos which both resulted in expected output. I've been unable to test the refactored Swift demos thus they will need more attention.

@amiecorso amiecorso removed their request for review October 6, 2020 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant