Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor should encode Unicode input as Punycode #12

Open
2 tasks
ypcrts opened this issue Apr 23, 2020 · 1 comment
Open
2 tasks

Constructor should encode Unicode input as Punycode #12

ypcrts opened this issue Apr 23, 2020 · 1 comment
Milestone

Comments

@ypcrts
Copy link
Owner

ypcrts commented Apr 23, 2020

Goal: implement RFC3492 https://tools.ietf.org/html/rfc3492

In the constructor, Unicode input should be encoded as Punycode.

TODO:

@wakemaster39
Copy link
Contributor

I think saving some sanity and dropping python 2 is a smart move. The last release ever is done now and officially retired as of Jan 1. I am a hard ass on this one though and trying to force people off of legacy python.

https://pypi.org/project/idna/ this one might solve both the python2.7 problem and make life a little easier. Saves having to figure out striping - off the end of strings if they are only ascii characters "test.com".encode('punycode') -> test.com-

Need to be careful with cached properties and how do you extract the original form of the URL if thats something that needs supporting.

@ypcrts ypcrts added this to the 1.6 milestone Jan 10, 2021
Repository owner locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants