Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Internationalized domain name (IDN) support #25

Open
PeterDaveHello opened this issue Nov 17, 2020 · 6 comments
Open

Comments

@PeterDaveHello
Copy link

Hello,

I just found this useful python tool, it looks great in most cases! Not sure is IDN support will be something you'd also like to have, it'll be awesome if it's also supported.

Currently, IDN will be considered as an invalid FQDN:

$ python
Python 3.6.9 (default, Jul 17 2020, 12:50:27) 
[GCC 8.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from fqdn import FQDN
>>> FQDN('Bücher.example').is_valid
False

Thank you!

@ypcrts
Copy link
Owner

ypcrts commented Nov 20, 2020 via email

@PeterDaveHello
Copy link
Author

Thank you @ypcrts 😃

@ypcrts
Copy link
Owner

ypcrts commented Dec 15, 2020

@PeterDaveHello

What is your use case for this? You want FQDN('Bücher.example').is_valid to return True. What do you want for the internal state? For example, do you want FQDN('Bücher.example').relative to return xn--bcher-kva.example or Bücher.example? Why?

Really, what I'm asking is, how is your use case different from #12 ?

@PeterDaveHello
Copy link
Author

To me personally I prefer .relative() to return xn--bcher-kva.example, because it's more comparable, one of the issues of IDN is the identifyability by human eyes, but I may need to dig more about how IDN is saved in the most popular DNS service providers.

@PeterDaveHello
Copy link
Author

I'm not pretty sure but this may just be duplicated with #12

@PeterDaveHello
Copy link
Author

cc @ross & octodns/octodns#199, octodns may be able to support IDN via the implementation here(and may also contribute back), I've already use this fqdn package in octodns to help fdqn validation (octodns/octodns#631)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants