Fix the namespace of horizontal-pod-autoscaler service account used in the helm chart #253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the namespace of horizontal-pod-autoscaler service account used in the helm chart.
Description
The incident reported in #252 occurs because cluster role bindings use wrong namespace for
horizontal-pod-autoscaler
service account. They get the namespace from{{ .Values.namespace }}
expression which has a value other thankube-system
.This PR fixes that issue by setting the namespace for
horizontal-pod-autoscaler
service account askube-system
.Types of Changes
Deployment Notes
Steps provided in #252 can be used to test this issue.