-
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): correct config parameters for Minoston MP21ZD Dimmer Plug #6686
Conversation
} | ||
], | ||
"metadata": { | ||
"inclusion": "1. Refer to your primary controller instructions to process the inclusion / exclusion setup procedure.\n2. When prompted by your primary controller, click the button three times in one second", | ||
"exclusion": "1. Refer to your primary controller instructions to process the inclusion / exclusion setup procedure.\n2. When prompted by your primary controller, click the button three times in one second", | ||
"reset": "Press click Z-Wave button 3 times quickly, and hold for at least 10 seconds at the third time to restore the device to the factory\n(Node:Please use this procedure only when the network primary controller is missing or otherwise inoperable.)", | ||
"manual": "https://products.z-wavealliance.org/ProductManual/File?folder=&filename=product_documents/4137/MP21ZD%20Manual-20210322.pdf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link opens a manual for the Minoston MP21ZS, not a MP21ZD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minoston offers a 700 and 800 series version of this plug, but both versions have the same parameter set reflected by this PR.
I have nightmares from the mess around those Minoston devices. Will have to look at this in depth before a review. |
Thanks for the patience and the PR! |
### Features * Add `ZWaveNode.createDump()` method to save debug information in a format Z-Wave JS understands (#6906) * Support node dumps created by `ZWaveNode.createDump()` as input for `mock-server' (#6907) * `mock-server`: enable mDNS discovery (#6909) * Add driver option to configure vendor-specific constants Z-Wave JS uses to reply to requests from other nodes, including manufacturer ID, product type/ID and hardware version (#6876) ### Bugfixes * Fixed a race condition that would cause a timeout error to be shown after an actually successful OTW update (#6912) * Create `supportedNotificationTypes` and `supportedNotificationEvents` values with `alarmMapping` compat flag (#6914) ### Config file changes * Correct config parameters for Minoston MP21ZD Dimmer Plug (#6686)
The existing configuration parameters for the MP21ZD were pulled from a similar, but different, Minoston dimmer plug and are mostly incorrect.
This PR corrects the configuration parameters for the MP21ZD, based on the parameters available in the user manual from Minoston: https://cdn-files.myshopline.com/file/store/1701829637050/MP21ZD(800-Series)-Manual.pdf
This required a few additions to the template config, for new parameters that appear to not have any prior work in existing template files.
I believe I followed all the style guide rules, to the best of my ability, but always open for feedback.
Thanks!
Fixes: #6902