feat: align Meter CC Reset v6 with specifications, add mocks, add API for report commands #6921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
changed the title
AlCalzone
added a commit
that referenced
this pull request
Jun 17, 2024
… for report commands (#6921)
AlCalzone
added a commit
that referenced
this pull request
Jun 17, 2024
… for report commands (#6921)
AlCalzone
added a commit
that referenced
this pull request
Jun 21, 2024
… for report commands (#6921)
AlCalzone
added a commit
that referenced
this pull request
Jun 24, 2024
… for report commands (#6921)
AlCalzone
added a commit
that referenced
this pull request
Jul 5, 2024
… for report commands (#6921)
AlCalzone
added a commit
that referenced
this pull request
Jul 5, 2024
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v13) * Align Meter CC Reset v6 with specifications, add mocks, add API for report commands (#6921) * Convert all Z-Wave specific configs except devices and manufacturers into code, move from ConfigManager methods to utility functions (#6925, #6929) * Remove `ZWaveApplicationHost` dependency from `CommandClass.toLogEntry()` (#6927) * Removed some deprecated things (#6928) * Replace `Controller.isAssociationAllowed` with `Controller.checkAssociation` (#6935) * Fixed health checks for ZWLR nodes, throw when requesting neighbors (#6939) * The repo now uses Yarn 4 and Corepack to manage its dependencies (#6949)
AlCalzone
added a commit
that referenced
this pull request
Jul 5, 2024
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v13) * Align Meter CC Reset v6 with specifications, add mocks, add API for report commands (#6921) * Convert all Z-Wave specific configs except devices and manufacturers into code, move from ConfigManager methods to utility functions (#6925, #6929) * Remove `ZWaveApplicationHost` dependency from `CommandClass.toLogEntry()` (#6927) * Removed some deprecated things (#6928) * Replace `Controller.isAssociationAllowed` with `Controller.checkAssociation` (#6935) * Fixed health checks for ZWLR nodes, throw when requesting neighbors (#6939) * The repo now uses Yarn 4 and Corepack to manage its dependencies (#6949) ### Changes under the hood * Upgrade to TypeScript 5.5 (#6919) * The root `tsconfig.json` is now set up in "solution-style", which should improve the goto references functionality. In addition, linting, testing and running locally no longer requires all modules to be compiled first. (#6748)
AlCalzone
added a commit
that referenced
this pull request
Jul 5, 2024
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v13) * Align Meter CC Reset v6 with specifications, add mocks, add API for report commands (#6921) * Convert all Z-Wave specific configs except devices and manufacturers into code, move from ConfigManager methods to utility functions (#6925, #6929) * Remove `ZWaveApplicationHost` dependency from `CommandClass.toLogEntry()` (#6927) * Removed some deprecated things (#6928) * Replace `Controller.isAssociationAllowed` with `Controller.checkAssociation` (#6935) * Fixed health checks for ZWLR nodes, throw when requesting neighbors (#6939) * The repo now uses Yarn 4 and Corepack to manage its dependencies (#6949) ### Changes under the hood * Upgrade to TypeScript 5.5 (#6919) * The root `tsconfig.json` is now set up in "solution-style", which should improve the goto references functionality. In addition, linting, testing and running locally no longer requires all modules to be compiled first. (#6748)
AlCalzone
added a commit
that referenced
this pull request
Jul 9, 2024
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v13) * Align Meter CC Reset v6 with specifications, add mocks, add API for report commands (#6921) * Convert all Z-Wave specific configs except devices and manufacturers into code, move from ConfigManager methods to utility functions (#6925, #6929) * Remove `ZWaveApplicationHost` dependency from `CommandClass.toLogEntry()` (#6927) * Removed some deprecated things (#6928) * Replace `Controller.isAssociationAllowed` with `Controller.checkAssociation` (#6935) * Fixed health checks for ZWLR nodes, throw when requesting neighbors (#6939) * The repo now uses Yarn 4 and Corepack to manage its dependencies (#6949) ### Changes under the hood * Upgrade to TypeScript 5.5 (#6919) * The root `tsconfig.json` is now set up in "solution-style", which should improve the goto references functionality. In addition, linting, testing and running locally no longer requires all modules to be compiled first. (#6748)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been found that the encoding of the Meter CC Reset command in version 6 was different from the specification. As a result, the
MeterCCResetOptionstype had to be changed, because all 4 fields are required to send a V6 command:This also means the
MeterCCAPI.reset(options)method signature has changed.Further changes in this PR:
resetvalues for single meters now refer to a combination of meter type/scale/rate type and are only created for accumulated scales, since others cannot be reset. This will leave some orphaned values that need a re-interview to be removed.resetvalue for all accumulated values now only refreshes accumulated values after the reset.MeterCCReportandMeterCCSupportedReportcan now be sent via theMeterCCAPImock-serverhave been added for Meter CC.fixes: #6794