fix: abort interview in more cases when node is dead #6967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Jun 26, 2024
AlCalzone
added a commit
that referenced
this pull request
Jun 26, 2024
### Bugfixes * Fixed an issue where the watchdog feature could cause Z-Wave JS to stall after attempting controller recovery (#6968) * Reset controller again when transmitting to a problematic node makes the controller become unresponsive again after automatic recovery (#6968) * Node interviews are now aborted in more cases when node is determined to be dead (#6967) * Expose Basic CC `currentValue` when certain compat flags are set (#6964)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some situations outside of the interview of "normal" CCs where a failure would not abort the interview. This was especially annoying when the failure was due to the node making the controller become unresponsive, as every attempt would take ages.
With this PR, we now abort in these situations too.