Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default paywall background with a lower quality image #1623

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Feb 21, 2024

Description

Equivalent to iOS's RevenueCat/purchases-ios#3379

Deals with: RevenueCat/purchases-flutter#982

This image is used in the default paywall when there is a problem with the configured paywall in the dashboard or there is no paywall configured. This image is blurred, so the quality is not really important here, and it was a pretty big image.

@tonidero tonidero added the refactor A code change that neither fixes a bug nor adds a feature label Feb 21, 2024
@tonidero tonidero requested a review from a team February 21, 2024 14:48
Copy link
Contributor

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e451b7) 83.67% compared to head (7ffea5f) 83.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1623   +/-   ##
=======================================
  Coverage   83.67%   83.67%           
=======================================
  Files         219      219           
  Lines        7343     7343           
  Branches     1023     1023           
=======================================
  Hits         6144     6144           
  Misses        799      799           
  Partials      400      400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonidero tonidero merged commit 252b408 into main Feb 21, 2024
9 checks passed
@tonidero tonidero deleted the change-default-paywall-background-lower-quality branch February 21, 2024 15:09
@NachoSoto
Copy link
Contributor

♥️

tonidero pushed a commit that referenced this pull request Feb 22, 2024
**This is an automatic release.**

### New Features
* Add setDisplayDismissButton to PaywallView (#1608) via Cesar de la
Vega (@vegaro)
### Bugfixes
* Fix runtime crash when using amazon and targetting android 14 (#1622)
via Toni Rico (@tonidero)
* Paywalls: No-op on all view model methods in the Loading paywall
screen (#1617) via Toni Rico (@tonidero)
* Fix safe insets on full screen (#1613) via Cesar de la Vega (@vegaro)
### Other Changes
* Change default paywall background with a lower quality image (#1623)
via Toni Rico (@tonidero)
* Fix load shedder integration tests (#1618) via Cesar de la Vega
(@vegaro)
* Refactor `presentedOfferingIdentifier` into `presentedOfferingContext`
object (#1612) via Toni Rico (@tonidero)
* [External] Update russian and kazakh translations (#1577 by @janbolat)
(#1616) via Toni Rico (@tonidero)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants