Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paywalls: optimize background.jpg image #3379

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Nov 2, 2023

This is only used for LoadingPaywallView and PaywallData.createDefault, both of which render it as a blurred image.
Therefore we don't need a high resolution image. This changes it from ~750KB to 100KB and the result isn't noticeable:

Before

image before

After

image after

This is only used for `LoadingPaywallView` and `PaywallData.createDefault`, both of which render it as a blurred image.
Therefore we don't need a high resolution image. This changes it from ~750KB to 100KB.
@NachoSoto NachoSoto added the build Changes that affect the build system label Nov 2, 2023
@NachoSoto NachoSoto requested review from a team November 2, 2023 17:21
@NachoSoto NachoSoto added perf A code change that improves performance and removed build Changes that affect the build system labels Nov 2, 2023
@NachoSoto NachoSoto merged commit a66fc2e into main Nov 2, 2023
17 of 19 checks passed
@NachoSoto NachoSoto deleted the paywalls-compress-background branch November 2, 2023 17:47
NachoSoto pushed a commit that referenced this pull request Nov 2, 2023
**This is an automatic release.**

### Performance Improvements
* `Paywalls`: optimize `background.jpg` image (#3379) via NachoSoto
(@NachoSoto)
### Other Changes
* `RevenueCatUI`: lowered CocoaPods deployment target to 11.0 (#3378)
via NachoSoto (@NachoSoto)
* Fix deprecation warning (#3371) via NachoSoto (@NachoSoto)
tonidero added a commit to RevenueCat/purchases-android that referenced this pull request Feb 21, 2024
### Description
Equivalent to iOS's
RevenueCat/purchases-ios#3379

Deals with: RevenueCat/purchases-flutter#982

This image is used in the default paywall when there is a problem with
the configured paywall in the dashboard or there is no paywall
configured. This image is blurred, so the quality is not really
important here, and it was a pretty big image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf A code change that improves performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants