Created `PostedTransactionCache` #2911

NachoSoto · 2023-07-27T15:55:09Z

This will be used to skip posting the same transaction multiple times, as a way to work around StoreKit reporting SK1 notifications from SK2 APIs.

NachoSoto · 2023-07-27T15:58:13Z

Sources/Caching/PostedTransactionCache.swift

+// TODO: tests
+// TODO: integrate
+
+final class PostedTransactionCache: PostedTransactionCacheType {


This uses DeviceCache underneath (composition, not inheritance). It also doesn't make DeviceCache have any more domain-specific caching code.

This is how I want to refactor DeviceCache so it's split in smaller classes.

Sources/Caching/DeviceCache.swift

NachoSoto · 2023-07-28T11:59:24Z

Tests/UnitTests/Caching/PostedTransactionCacheTests.swift

+        self.userDefaults = try XCTUnwrap(.init(suiteName: UUID().uuidString))
+        self.deviceCache = .init(sandboxEnvironmentDetector: MockSandboxEnvironmentDetector(isSandbox: true),
+                                 userDefaults: self.userDefaults)
+        self.cache = .init(deviceCache: self.deviceCache)


I decided to test with with real DeviceCache and UserDefaults which is a lot more accurate and less painful.

codecov · 2023-07-28T12:10:17Z

Codecov Report

Merging #2911 (a6777aa) into main (f4fa4d2) will increase coverage by 0.02%.
The diff coverage is 97.77%.

@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
+ Coverage   86.60%   86.63%   +0.02%     
==========================================
  Files         217      218       +1     
  Lines       15517    15545      +28     
==========================================
+ Hits        13439    13467      +28     
  Misses       2078     2078

Files Changed	Coverage Δ
Sources/Caching/DeviceCache.swift	`93.04% <96.87%> (+0.47%)`	⬆️
Sources/Caching/PostedTransactionCache.swift	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

NachoSoto · 2023-08-03T18:18:06Z

Sources/Caching/PostedTransactionCache.swift

+    }
+
+    func savePostedTransaction(_ transaction: StoreTransactionType) {
+        self.deviceCache.update(key: CacheKey.transactions,


TODO: do a quick test on device with N x 1000 transactions.

joshdholtz

Small question but not show stopping. Looks good 👍

joshdholtz · 2023-08-07T10:17:47Z

Sources/Caching/DeviceCache.swift

@@ -552,47 +569,56 @@ private extension DeviceCache {
        _ userDefaults: UserDefaults,
        productEntitlementMapping mapping: ProductEntitlementMapping
    ) {
-        guard let data = try? JSONEncoder.default.encode(value: mapping, logErrors: true) else {
-            return
+        if userDefaults.set(codable: mapping,


Is there any sort of error that we should be logging if this fails?

NachoSoto · 2023-08-07T15:51:31Z

Sources/Caching/DeviceCache.swift

+    /// - Returns: whether the value could be saved
+    @discardableResult
+    func set<T: Codable>(codable: T, forKey key: DeviceCacheKeyType) -> Bool {
+        guard let data = try? JSONEncoder.default.encode(value: codable, logErrors: true) else {


@joshdholtz this logErrors: true answers your question.

@NachoSoto

_This release is compatible with Xcode 15 beta 6 and visionOS beta 3_ ### Bugfixes * `visionOS`: support for `Xcode 15 beta 6` (#2989) via NachoSoto (@NachoSoto) * `CachingProductsManager`: avoid crash when caching different products with same identifier (#2979) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: disambiguate transactions from the queue (#2890) via NachoSoto (@NachoSoto) ### Performance Improvements * `StoreKit2TransactionListener`: handle transactions asynchronously (#2910) via NachoSoto (@NachoSoto) ### Other Changes * `Atomic`: avoid race conditions modifying dictionaries (#2981) via NachoSoto (@NachoSoto) * `Logging`: avoid logging "updating offerings" when request is cached (#2904) via NachoSoto (@NachoSoto) * `StoreKit2TransactionListener`: converted into an `actor` (#2909) via NachoSoto (@NachoSoto) * `Integration Tests`: added more observer mode tests (#2905) via NachoSoto (@NachoSoto) * Created `PostedTransactionCache` (#2911) via NachoSoto (@NachoSoto) * `IntroEligibility`: changed products to `Set<String>` (#2976) via NachoSoto (@NachoSoto) * `AdServices`: Rename `postAdServicesTokenIfNeeded()` to `postAdServicesTokenOncePerInstallIfNeeded()` (#2968) via Josh Holtz (@joshdholtz) * `SK1StoreProduct`: changed `productType` warning to debug (#2957) via NachoSoto (@NachoSoto) * `PrivacyInfo.xcprivacy`: added `UserDefaults` to access API types (#2913) via NachoSoto (@NachoSoto) * `Integration Tests`: new test to verify that SK1 purchases don't leave SK2 unfinished transactions (#2906) via NachoSoto (@NachoSoto) * `Logging`: log entire cache key with verbose logs (#2888) via NachoSoto (@NachoSoto) * `StoreProduct`: added test covering warning log (#2897) via NachoSoto (@NachoSoto) * `CustomEntitlementComputation`: use custom API key (#2879) via Toni Rico (@tonidero) * `CachingProductsManager`: removed duplicate log and added tests (#2898) via NachoSoto (@NachoSoto) * `Xcode 15 beta 5`: fixed test compilation (#2885) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>

This will be used to skip posting the same transaction multiple times, as a way to work around StoreKit reporting SK1 notifications from SK2 APIs.

@NachoSoto

_This release is compatible with Xcode 15 beta 6 and visionOS beta 3_ ### Bugfixes * `visionOS`: support for `Xcode 15 beta 6` (#2989) via NachoSoto (@NachoSoto) * `CachingProductsManager`: avoid crash when caching different products with same identifier (#2979) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: disambiguate transactions from the queue (#2890) via NachoSoto (@NachoSoto) ### Performance Improvements * `StoreKit2TransactionListener`: handle transactions asynchronously (#2910) via NachoSoto (@NachoSoto) ### Other Changes * `Atomic`: avoid race conditions modifying dictionaries (#2981) via NachoSoto (@NachoSoto) * `Logging`: avoid logging "updating offerings" when request is cached (#2904) via NachoSoto (@NachoSoto) * `StoreKit2TransactionListener`: converted into an `actor` (#2909) via NachoSoto (@NachoSoto) * `Integration Tests`: added more observer mode tests (#2905) via NachoSoto (@NachoSoto) * Created `PostedTransactionCache` (#2911) via NachoSoto (@NachoSoto) * `IntroEligibility`: changed products to `Set<String>` (#2976) via NachoSoto (@NachoSoto) * `AdServices`: Rename `postAdServicesTokenIfNeeded()` to `postAdServicesTokenOncePerInstallIfNeeded()` (#2968) via Josh Holtz (@joshdholtz) * `SK1StoreProduct`: changed `productType` warning to debug (#2957) via NachoSoto (@NachoSoto) * `PrivacyInfo.xcprivacy`: added `UserDefaults` to access API types (#2913) via NachoSoto (@NachoSoto) * `Integration Tests`: new test to verify that SK1 purchases don't leave SK2 unfinished transactions (#2906) via NachoSoto (@NachoSoto) * `Logging`: log entire cache key with verbose logs (#2888) via NachoSoto (@NachoSoto) * `StoreProduct`: added test covering warning log (#2897) via NachoSoto (@NachoSoto) * `CustomEntitlementComputation`: use custom API key (#2879) via Toni Rico (@tonidero) * `CachingProductsManager`: removed duplicate log and added tests (#2898) via NachoSoto (@NachoSoto) * `Xcode 15 beta 5`: fixed test compilation (#2885) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>

NachoSoto added the perf A code change that improves performance label Jul 27, 2023

NachoSoto requested a review from a team July 27, 2023 15:55

NachoSoto marked this pull request as draft July 27, 2023 15:55

NachoSoto force-pushed the cache-posted-transactions branch from 7358b35 to d3cd8ed Compare July 27, 2023 15:56

NachoSoto commented Jul 27, 2023

View reviewed changes

Sources/Caching/DeviceCache.swift Show resolved Hide resolved

NachoSoto changed the title ~~[WIP] Created PostedTransactionCache~~ Created PostedTransactionCache Jul 28, 2023

NachoSoto added refactor A code change that neither fixes a bug nor adds a feature and removed perf A code change that improves performance labels Jul 28, 2023

NachoSoto commented Jul 28, 2023

View reviewed changes

NachoSoto commented Aug 3, 2023

View reviewed changes

NachoSoto added 2 commits August 3, 2023 14:25

[WIP] Created PostedTransactionCache

77253e5

Added tests

a6777aa

NachoSoto force-pushed the cache-posted-transactions branch from b3ceb83 to a6777aa Compare August 3, 2023 21:26

NachoSoto marked this pull request as ready for review August 3, 2023 21:26

NachoSoto assigned aboedo Aug 3, 2023

NachoSoto added the PostReceipt optimizations label Aug 3, 2023

NachoSoto mentioned this pull request Aug 3, 2023

TransactionPoster: avoid posting transactions multiple times #2914

Closed

4 tasks

joshdholtz approved these changes Aug 7, 2023

View reviewed changes

NachoSoto commented Aug 7, 2023

View reviewed changes

NachoSoto merged commit 2b87c30 into main Aug 7, 2023
14 checks passed

NachoSoto deleted the cache-posted-transactions branch August 7, 2023 22:41

This was referenced Aug 9, 2023

[AUTOMATIC] Release/4.25.3 #2993

Closed

[AUTOMATIC] Release/4.25.3 #2994

Merged

MarkVillacampa pushed a commit that referenced this pull request Sep 6, 2023

Created PostedTransactionCache (#2911)

f75c5c4

This will be used to skip posting the same transaction multiple times, as a way to work around StoreKit reporting SK1 notifications from SK2 APIs.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created `PostedTransactionCache` #2911

Created `PostedTransactionCache` #2911

NachoSoto commented Jul 27, 2023 •

edited

Loading

NachoSoto Jul 27, 2023

NachoSoto Jul 28, 2023

codecov bot commented Jul 28, 2023 •

edited

Loading

NachoSoto Aug 3, 2023

joshdholtz left a comment

joshdholtz Aug 7, 2023

NachoSoto Aug 7, 2023

Created PostedTransactionCache #2911

Created PostedTransactionCache #2911

Conversation

NachoSoto commented Jul 27, 2023 • edited Loading

NachoSoto Jul 27, 2023

Choose a reason for hiding this comment

NachoSoto Jul 28, 2023

Choose a reason for hiding this comment

codecov bot commented Jul 28, 2023 • edited Loading

Codecov Report

NachoSoto Aug 3, 2023

Choose a reason for hiding this comment

joshdholtz left a comment

Choose a reason for hiding this comment

joshdholtz Aug 7, 2023

Choose a reason for hiding this comment

NachoSoto Aug 7, 2023

Choose a reason for hiding this comment

Created `PostedTransactionCache` #2911

Created `PostedTransactionCache` #2911

NachoSoto commented Jul 27, 2023 •

edited

Loading

codecov bot commented Jul 28, 2023 •

edited

Loading