visionOS: support for Xcode 15 beta 6
#2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
force-pushed
the
visionos-beta-3
branch
from
81e07d1
to
def42cc
Compare
NachoSoto
changed the title
visionOS: support for Xcode 15 beta 6visionOS: support for Xcode 15 beta 6
NachoSoto
force-pushed
the
visionos-beta-3
branch
3 times, most recently
from
735f9b1
to
bee593d
Compare
NachoSoto
force-pushed
the
visionos-beta-3
branch
from
bee593d
to
b1c44c8
Compare
Codecov Report
@@ Coverage Diff @@
## main #2989 +/- ##
==========================================
+ Coverage 86.56% 86.70% +0.14%
==========================================
Files 218 218
Lines 15623 15617 -6
==========================================
+ Hits 13524 13541 +17
+ Misses 2099 2076 -23
|
NachoSoto
added a commit
that referenced
this pull request
Aug 9, 2023
_This release is compatible with Xcode 15 beta 6 and visionOS beta 3_ ### Bugfixes * `visionOS`: support for `Xcode 15 beta 6` (#2989) via NachoSoto (@NachoSoto) * `CachingProductsManager`: avoid crash when caching different products with same identifier (#2979) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: disambiguate transactions from the queue (#2890) via NachoSoto (@NachoSoto) ### Performance Improvements * `StoreKit2TransactionListener`: handle transactions asynchronously (#2910) via NachoSoto (@NachoSoto) ### Other Changes * `Atomic`: avoid race conditions modifying dictionaries (#2981) via NachoSoto (@NachoSoto) * `Logging`: avoid logging "updating offerings" when request is cached (#2904) via NachoSoto (@NachoSoto) * `StoreKit2TransactionListener`: converted into an `actor` (#2909) via NachoSoto (@NachoSoto) * `Integration Tests`: added more observer mode tests (#2905) via NachoSoto (@NachoSoto) * Created `PostedTransactionCache` (#2911) via NachoSoto (@NachoSoto) * `IntroEligibility`: changed products to `Set<String>` (#2976) via NachoSoto (@NachoSoto) * `AdServices`: Rename `postAdServicesTokenIfNeeded()` to `postAdServicesTokenOncePerInstallIfNeeded()` (#2968) via Josh Holtz (@joshdholtz) * `SK1StoreProduct`: changed `productType` warning to debug (#2957) via NachoSoto (@NachoSoto) * `PrivacyInfo.xcprivacy`: added `UserDefaults` to access API types (#2913) via NachoSoto (@NachoSoto) * `Integration Tests`: new test to verify that SK1 purchases don't leave SK2 unfinished transactions (#2906) via NachoSoto (@NachoSoto) * `Logging`: log entire cache key with verbose logs (#2888) via NachoSoto (@NachoSoto) * `StoreProduct`: added test covering warning log (#2897) via NachoSoto (@NachoSoto) * `CustomEntitlementComputation`: use custom API key (#2879) via Toni Rico (@tonidero) * `CachingProductsManager`: removed duplicate log and added tests (#2898) via NachoSoto (@NachoSoto) * `Xcode 15 beta 5`: fixed test compilation (#2885) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
NachoSoto
added a commit
that referenced
this pull request
Aug 11, 2023
…3005) Fixes #2998. See #2989 for why this is needed in the first place. This is now fixed in SPM: swiftlang/swift-package-manager#6794, but we need a workaround for now. Since `.custom` doesn't work properly (it gets evaluated in Xcode even outside of that platform), this splits `Package.swift` based on Xcode version. Thanks @neonichu for helping with this.
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
### Context: `#if os(iOS)` no longer evaluates to `true` when compiling for `visionOS` Which means we need `|| os(xrOS)`. But to support older Xcode we need `#if swift(>=5.9) && os(xrOS)`. But, fun fact, short-circuiting doesn’t work in `Xcode 13`. And we still need that to run iOS <15 tests (`FB12223404` / `FB12805891`) 💩 This works around that by defining our own `VISION_OS` flag. ### Changes: - Added `VISION_OS` compile time flag to determine SDK - Replaced `#if os(xrOS)` with `#if VISION_OS` - Added flag to `Package.swift` (thanks @neonichu for helping with this)
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
_This release is compatible with Xcode 15 beta 6 and visionOS beta 3_ ### Bugfixes * `visionOS`: support for `Xcode 15 beta 6` (#2989) via NachoSoto (@NachoSoto) * `CachingProductsManager`: avoid crash when caching different products with same identifier (#2979) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: disambiguate transactions from the queue (#2890) via NachoSoto (@NachoSoto) ### Performance Improvements * `StoreKit2TransactionListener`: handle transactions asynchronously (#2910) via NachoSoto (@NachoSoto) ### Other Changes * `Atomic`: avoid race conditions modifying dictionaries (#2981) via NachoSoto (@NachoSoto) * `Logging`: avoid logging "updating offerings" when request is cached (#2904) via NachoSoto (@NachoSoto) * `StoreKit2TransactionListener`: converted into an `actor` (#2909) via NachoSoto (@NachoSoto) * `Integration Tests`: added more observer mode tests (#2905) via NachoSoto (@NachoSoto) * Created `PostedTransactionCache` (#2911) via NachoSoto (@NachoSoto) * `IntroEligibility`: changed products to `Set<String>` (#2976) via NachoSoto (@NachoSoto) * `AdServices`: Rename `postAdServicesTokenIfNeeded()` to `postAdServicesTokenOncePerInstallIfNeeded()` (#2968) via Josh Holtz (@joshdholtz) * `SK1StoreProduct`: changed `productType` warning to debug (#2957) via NachoSoto (@NachoSoto) * `PrivacyInfo.xcprivacy`: added `UserDefaults` to access API types (#2913) via NachoSoto (@NachoSoto) * `Integration Tests`: new test to verify that SK1 purchases don't leave SK2 unfinished transactions (#2906) via NachoSoto (@NachoSoto) * `Logging`: log entire cache key with verbose logs (#2888) via NachoSoto (@NachoSoto) * `StoreProduct`: added test covering warning log (#2897) via NachoSoto (@NachoSoto) * `CustomEntitlementComputation`: use custom API key (#2879) via Toni Rico (@tonidero) * `CachingProductsManager`: removed duplicate log and added tests (#2898) via NachoSoto (@NachoSoto) * `Xcode 15 beta 5`: fixed test compilation (#2885) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
…3005) Fixes #2998. See #2989 for why this is needed in the first place. This is now fixed in SPM: swiftlang/swift-package-manager#6794, but we need a workaround for now. Since `.custom` doesn't work properly (it gets evaluated in Xcode even outside of that platform), this splits `Package.swift` based on Xcode version. Thanks @neonichu for helping with this.
NachoSoto
added a commit
that referenced
this pull request
Jan 30, 2024
### Changes: - Added `visionOS` to list of deployment targets in `Podspec` - ~~Updated `Swift` version to 5.7 (see https://swiftversion.net), Xcode 14.0 is required, and that's Swift 5.7. We no longer support 5.5~~ (done in a previous PR already) - Added `visionOS` CocoaPods lint check to `build_visionos` - Added `VISION_OS` to Podspec (see #2989) - ~~Changed `visionOS` CI job to use `Xcode 15 beta 8` (see https://discuss.circleci.com/t/xcode-15-rc-released-important-notice-for-visionos-sdk-users/49278)~~ (no longer needed) Fixes https://community.revenuecat.com/sdks-51/how-to-support-visionos-via-cocoapods-3499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
#if os(iOS)no longer evaluates totruewhen compiling forvisionOSWhich means we need
|| os(xrOS).But to support older Xcode we need
#if swift(>=5.9) && os(xrOS).But, fun fact, short-circuiting doesn’t work in
Xcode 13.And we still need that to run iOS <15 tests (
FB12223404/FB12805891)💩
This works around that by defining our own
VISION_OSflag.Changes:
VISION_OScompile time flag to determine SDK#if os(xrOS)with#if VISION_OSPackage.swift(thanks @neonichu for helping with this)