-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CocoaPods
: enabled visionOS
#3262
Conversation
We might have to bump the jobs to Xcode 15.0, but wanted to see whether this is working for now. |
6cbb1bb
to
0ca4e91
Compare
claide (1.0.3) | ||
cocoapods (1.12.1) | ||
claide (1.1.0) | ||
cocoapods (1.13.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to update it here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update! 👏 Excited to see the addition of visionOS to the deployment targets in the Podspec. Thanks for keeping the Swift version up-to-date and providing clear instructions on the required Xcode version. The integration of the visionOS CocoaPods lint check and the switch to Xcode 15 beta 8 for the CI job make it even better.
However, I noticed the mention of the issue CocoaPods/CocoaPods#11965. Any insights on how this is being addressed or any potential workarounds? Looking forward to the continued progress! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for it on CocoaPods is still not working: CocoaPods/CocoaPods#12159 (comment)
We haven't received an update from them, so until then unfortunately we can't release this.
Blocked by CocoaPods/CocoaPods#11965 (comment) |
Extracted this from #3262 since that's blocked by CocoaPods.
aabaad3
to
5aee107
Compare
fastlane/Fastfile
Outdated
pod_lib_lint( | ||
verbose: true, | ||
podspec:'RevenueCat.podspec', | ||
platforms:"xros", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Xcode 15.1 beta 3 changes this to visionos
so this will probably have to change too.
Reminder that we need to add this to RevenueCatUI too (see #3368) |
2ecb63e
to
89ef805
Compare
- Added `visionOS` to list of deployment targets in `Podspec` - Updated `Swift` version to 5.7 (see https://swiftversion.net/), Xcode 14.0 is required, and that's Swift 5.7. We no longer support 5.5 - Added `visionOS` to release checks
89ef805
to
d9e3dce
Compare
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' } | ||
s.pod_target_xcconfig = { | ||
'DEFINES_MODULE' => 'YES', | ||
'SWIFT_ACTIVE_COMPILATION_CONDITIONS[sdk=xros*]' => '$(inherited) VISION_OS', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is new.
6e5c899
to
1539642
Compare
Changes:
visionOS
to list of deployment targets inPodspec
Updated(done in a previous PR already)Swift
version to 5.7 (see https://swiftversion.net), Xcode 14.0 is required, and that's Swift 5.7. We no longer support 5.5visionOS
CocoaPods lint check tobuild_visionos
VISION_OS
to Podspec (seevisionOS
: support forXcode 15 beta 6
#2989)Changed(no longer needed)visionOS
CI job to useXcode 15 beta 8
(see https://discuss.circleci.com/t/xcode-15-rc-released-important-notice-for-visionos-sdk-users/49278)Fixes https://community.revenuecat.com/sdks-51/how-to-support-visionos-via-cocoapods-3499