-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
visionOS
: changed CI job to Release
#3042
Conversation
The `build_tv_watch_mac` job already builds on Release mode (`Carthage`'s default). This would have also helped detect the issue fixed by #3034. I've also changed the API tester jobs to compile on release, though those aren't ran by CI.
@@ -237,7 +238,8 @@ platform :ios do | |||
xcodebuild( | |||
workspace: 'RevenueCat.xcworkspace', | |||
scheme: 'SwiftAPITester', | |||
destination: 'generic/platform=iOS Simulator' | |||
destination: 'generic/platform=iOS Simulator', | |||
configuration: 'release', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should build the api tests in both debug and release, in case we have any debug-only apis... I agree release is more important though, so this makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We compile API testers in debug when running tests.
**This is an automatic release.** ### Other Changes * `Integration Tests`: test that `checkTrialOrIntroDiscountEligibility` makes no API requests (#3054) via NachoSoto (@NachoSoto) * `visionOS`: changed CI job to Release (#3042) via NachoSoto (@NachoSoto) * `StoreKit 2`: added warning to paywall constructors (#3045) via NachoSoto (@NachoSoto) * `README`: added `visionOS` to list of supported platforms (#3052) via NachoSoto (@NachoSoto) * `Tests`: added tests for `ClockType` (#3029) via NachoSoto (@NachoSoto) * `HTTPClient`: also parse errors with `application/json;charset=utf8` (#3041) via NachoSoto (@NachoSoto)
**This is an automatic release.** ### Other Changes * `Integration Tests`: test that `checkTrialOrIntroDiscountEligibility` makes no API requests (#3054) via NachoSoto (@NachoSoto) * `visionOS`: changed CI job to Release (#3042) via NachoSoto (@NachoSoto) * `StoreKit 2`: added warning to paywall constructors (#3045) via NachoSoto (@NachoSoto) * `README`: added `visionOS` to list of supported platforms (#3052) via NachoSoto (@NachoSoto) * `Tests`: added tests for `ClockType` (#3029) via NachoSoto (@NachoSoto) * `HTTPClient`: also parse errors with `application/json;charset=utf8` (#3041) via NachoSoto (@NachoSoto)
The
build_tv_watch_mac
job already builds on Release mode (Carthage
's default).This would have also helped detect the issue fixed by #3034.
I've also changed the API tester jobs to compile on release, though those aren't ran by CI.