Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visionOS: changed CI job to Release #3042

Merged
merged 1 commit into from
Aug 22, 2023
Merged

visionOS: changed CI job to Release #3042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ platform :ios do
workspace: 'RevenueCat.xcworkspace',
scheme: 'RevenueCat',
destination: 'generic/platform=visionOS',
configuration: 'release',
xcargs: "CODE_SIGN_IDENTITY='' CODE_SIGNING_REQUIRED=NO"
)
end
Expand Down Expand Up @@ -237,7 +238,8 @@ platform :ios do
xcodebuild(
workspace: 'RevenueCat.xcworkspace',
scheme: 'SwiftAPITester',
destination: 'generic/platform=iOS Simulator'
destination: 'generic/platform=iOS Simulator',
configuration: 'release',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should build the api tests in both debug and release, in case we have any debug-only apis... I agree release is more important though, so this makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We compile API testers in debug when running tests.

)
end

Expand All @@ -246,7 +248,8 @@ platform :ios do
xcodebuild(
workspace: 'RevenueCat.xcworkspace',
scheme: 'ObjCAPITester',
destination: 'generic/platform=iOS Simulator'
destination: 'generic/platform=iOS Simulator',
configuration: 'release',
)
end

Expand All @@ -256,7 +259,8 @@ platform :ios do
project: 'Tests/APITesters/CustomEntitlementComputationSwiftAPITester/CustomEntitlementComputationSwiftAPITester.xcodeproj',
scheme: 'SwiftAPITester',
destination: 'generic/platform=iOS',
xcargs: "CODE_SIGN_IDENTITY='' CODE_SIGNING_REQUIRED=NO"
xcargs: "CODE_SIGN_IDENTITY='' CODE_SIGNING_REQUIRED=NO",
configuration: 'release',
)
end

Expand Down