Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0 (aka 1.0.0) #238

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

2.0.0 (aka 1.0.0) #238

wants to merge 61 commits into from

Commits on May 29, 2016

  1. Removed for-sure deprecated constants

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    5e74be1 View commit details
    Browse the repository at this point in the history

  2. Removed deprecated Result from project

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    bde2696 View commit details
    Browse the repository at this point in the history

  3. Removed deprecated MulticastResult from project

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    3e4b168 View commit details
    Browse the repository at this point in the history

  4. Removed comment from node-gcm.js

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    b1bbff0 View commit details
    Browse the repository at this point in the history

  5. Removed deprecated methods Message#addDataWith{KeyValue,Object} from … 

    …project
    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    7d34f01 View commit details
    Browse the repository at this point in the history

  6. Removed tests for now-removed funcitonality

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    c85f66a View commit details
    Browse the repository at this point in the history

  7. Version bump and CHANGELOG for -alpha.0

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    022f6f3 View commit details
    Browse the repository at this point in the history

  8. Make it clear that this is v1 readme

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    dce3ae7 View commit details
    Browse the repository at this point in the history

  9. Make Sender#send{,NoRetry} expect a raw JSON object 

    It validates and everything internally
    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    6d50454 View commit details
    Browse the repository at this point in the history

  10. Remove Message from lib, no longer used

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    4e2446c View commit details
    Browse the repository at this point in the history

  11. Simply export the sender

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    a92d737 View commit details
    Browse the repository at this point in the history

  12. No mapping of argument names: simply use the names that the FCM servi… 

    …ce expects
    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    ee1ce8a View commit details
    Browse the repository at this point in the history

  13. cleaned up comment in message-options

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    b87b3ad View commit details
    Browse the repository at this point in the history

  14. Adjusted README to show this new reality -- much simpler!

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    141e998 View commit details
    Browse the repository at this point in the history

  15. Updated the usage section to fit the real code

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    3a5fe3f View commit details
    Browse the repository at this point in the history

  16. More adjustments to the README

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    a3dcac0 View commit details
    Browse the repository at this point in the history

  17. Updated example to new reality

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    8f93ad8 View commit details
    Browse the repository at this point in the history

  18. Adjust sender specs to new reality

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    9a4b643 View commit details
    Browse the repository at this point in the history

  19. Add a test that invalid or wrong properties are ignored

    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    93aa28d View commit details
    Browse the repository at this point in the history

  20. Remove message specs, no longer needed 

    What they covered before is now covered by sender
    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    f3208cf View commit details
    Browse the repository at this point in the history

  21. Depend only on lodash.defaultsdeep (instead of all lodash) 

    This makes for a significantly smaller dependency tree (lodash is 2Mb, lodash.defaultsdeep is around 250kb)
    @hypesystem
    hypesystem committed May 29, 2016
    Configuration menu
    Copy the full SHA
    3784ce4 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2016

  1. Merge pull request #239 from ToothlessGear/v1-remove-message 

    V1: remove Message
    @eladnava
    eladnava committed May 30, 2016
    Configuration menu
    Copy the full SHA
    201f37b View commit details
    Browse the repository at this point in the history

  2. Merge pull request #240 from ToothlessGear/v1-smaller-lodash-dep 

    V1: Depend only on lodash.defaultsdeep (instead of all lodash)
    @eladnava
    eladnava committed May 30, 2016
    Configuration menu
    Copy the full SHA
    b4eae56 View commit details
    Browse the repository at this point in the history

  3. Add entries to .gitignore (vscode & test.js)

    @eladnava
    eladnava committed May 30, 2016
    Configuration menu
    Copy the full SHA
    022ce33 View commit details
    Browse the repository at this point in the history

  4. Only allow arrays or strings as recipients -- move closer to the API … 

    …interface

Remove unnecessary logic :-)
Now we just do what the HTTP interface makes natural: a single recipient goes in the `to` field; multiple recipients go in the `registration_ids` field
    @hypesystem
    hypesystem committed May 30, 2016
    Configuration menu
    Copy the full SHA
    8160865 View commit details
    Browse the repository at this point in the history

  5. Still check if the array is empty, though

    @hypesystem
    hypesystem committed May 30, 2016
    Configuration menu
    Copy the full SHA
    976a02c View commit details
    Browse the repository at this point in the history

  6. Return error objects instead of strings

    @hypesystem
    hypesystem committed May 30, 2016
    Configuration menu
    Copy the full SHA
    ea0a850 View commit details
    Browse the repository at this point in the history

  7. Remove all the specs that had to do with the special recipient format… 

    …tings!
    @hypesystem
    hypesystem committed May 30, 2016
    Configuration menu
    Copy the full SHA
    9ab4d23 View commit details
    Browse the repository at this point in the history

  8. Update README to match new interface

    @hypesystem
    hypesystem committed May 30, 2016
    Configuration menu
    Copy the full SHA
    e62aaae View commit details
    Browse the repository at this point in the history

Commits on May 31, 2016

  1. Fixed typo in README (og -> or)

    @hypesystem
    hypesystem committed May 31, 2016
    Configuration menu
    Copy the full SHA
    f3d0c9f View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2016

  1. Merge pull request #242 from ToothlessGear/v1-simpler-recipient-arg 

    V1: simpler recipient arg
    @hypesystem
    hypesystem committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    2048582 View commit details
    Browse the repository at this point in the history

  2. Remove sendNoRetry from being exposed

    @hypesystem
    hypesystem committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    22a07f3 View commit details
    Browse the repository at this point in the history

  3. Rename sendNoRetry -> sendMessage

    @hypesystem
    hypesystem committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    3d8b4f6 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary support for no callback (always called with callba… 

    …ck!)
    @hypesystem
    hypesystem committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    81c27c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2016

  1. Rewrite sendNoRetry tests to use send with retries: 0

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    3d18769 View commit details
    Browse the repository at this point in the history

  2. Extract sendMessageWithRetries function

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    0e6d133 View commit details
    Browse the repository at this point in the history

  3. Modify retry to use sendMessageWithRetries

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    008e2fd View commit details
    Browse the repository at this point in the history

  4. Added a note about a case that seems odd

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    cf7b494 View commit details
    Browse the repository at this point in the history

  5. Remove self argument from retry and sendMessageWithRetries

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    0236fbf View commit details
    Browse the repository at this point in the history

  6. Get request body early on, simply pass it through

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    d125924 View commit details
    Browse the repository at this point in the history

  7. fix indentation

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    d4eec16 View commit details
    Browse the repository at this point in the history

  8. Build requestOptions early and pass around (instead of building for e… 

    …ach request!
    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    d174ce7 View commit details
    Browse the repository at this point in the history

  9. Reorder functions

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    e177346 View commit details
    Browse the repository at this point in the history

  10. Remove an irrelevant return

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    c558a7c View commit details
    Browse the repository at this point in the history

  11. Removed redundant tests (now covered by send with retries: 0)

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    7a0e08e View commit details
    Browse the repository at this point in the history

  12. Dont try to mock sendNoRetry

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    e0a6969 View commit details
    Browse the repository at this point in the history

  13. Removed some more redundant tests

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    e8dd0ff View commit details
    Browse the repository at this point in the history

  14. Make all send specs async

    @hypesystem
    hypesystem committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    9c32fb2 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2016

  1. Break out of retry if there are no retries left!

    @hypesystem
    hypesystem committed Jun 8, 2016
    Configuration menu
    Copy the full SHA
    79873f8 View commit details
    Browse the repository at this point in the history

  2. Remove this one weird case that is good for naught

    @hypesystem
    hypesystem committed Jun 8, 2016
    Configuration menu
    Copy the full SHA
    20fad62 View commit details
    Browse the repository at this point in the history

  3. Make send() tests work. 

    This required some major changes to how the tests are structured, as I didnt want to be listening on what used to be "sendNoRetry".
requestStub is now a sinon spy.
it is reset before EVERY test (woops, before we only cleared state before each test CATEGORY)
and how we expect some things has changed as a result of these structural changes
    @hypesystem
    hypesystem committed Jun 8, 2016
    Configuration menu
    Copy the full SHA
    41b2d94 View commit details
    Browse the repository at this point in the history

  4. merge two tests, so the same on now tests sender options and auth key

    @hypesystem
    hypesystem committed Jun 8, 2016
    Configuration menu
    Copy the full SHA
    a1343eb View commit details
    Browse the repository at this point in the history

  5. Remove two tests that no longer pass (and shouldnt!) 

    They used the registration_ids key, which we will no longer support.
They passed because state was NOT reset before every test (fixed this in earlier commit)
    @hypesystem
    hypesystem committed Jun 8, 2016
    Configuration menu
    Copy the full SHA
    7e55699 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2016

  1. Merge pull request #248 from ToothlessGear/v1-no-send-no-retry 

    V1 no send no retry
    @hypesystem
    hypesystem committed Jun 9, 2016
    Configuration menu
    Copy the full SHA
    7286a4b View commit details
    Browse the repository at this point in the history

  2. Update README for no sendNoRetry

    @hypesystem
    hypesystem committed Jun 9, 2016
    Configuration menu
    Copy the full SHA
    c89d01a View commit details
    Browse the repository at this point in the history

  3. vbump 1.0.0-alpha.1 and CHANGELOG

    @hypesystem
    hypesystem committed Jun 9, 2016
    Configuration menu
    Copy the full SHA
    3476392 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2016

  1. Upgrade debug

    @ratson
    ratson committed Jul 17, 2016
    Configuration menu
    Copy the full SHA
    5fd55d7 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2016

  1. Update contributors

    @ratson
    ratson committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    7876a2d View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2016

  1. Merge pull request #260 from ratson/debug-v2 

    Upgrade debug
    @hypesystem
    hypesystem committed Aug 5, 2016
    Configuration menu
    Copy the full SHA
    3901643 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2016

  1. Return a Promise from Sender.send() if it is called without a callback.

    Dan Perron committed Aug 8, 2016
    Configuration menu
    Copy the full SHA
    fb8cbb8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #264 from dan-perron/v1-promises 

    promisify node-gcm
    @hypesystem
    hypesystem committed Aug 8, 2016
    Configuration menu
    Copy the full SHA
    c829e37 View commit details
    Browse the repository at this point in the history