Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macro_names rule complains about "STAGED_CONTENT(Path)" #41

Closed
jfacorro opened this issue Jul 17, 2014 · 1 comment
Closed

macro_names rule complains about "STAGED_CONTENT(Path)" #41

jfacorro opened this issue Jul 17, 2014 · 1 comment
Labels
bug

Comments

@jfacorro
Copy link
Contributor

Since this rule is validating that every alphanumeric character between -define( and the first , is upper case, when defining a macro with arguments it fails.

-define(STAGED_CONTENT(Path),
        "git show :" ++ Path).
@jfacorro jfacorro added the bug label Jul 17, 2014
@elbrujohalcon
Copy link
Member

nice catch!!

jfacorro added a commit that referenced this issue Jul 24, 2014
@jfacorro
[#41] Removed auto-inserted closing parens.
b20b778
elbrujohalcon added a commit that referenced this issue Jul 24, 2014
@elbrujohalcon
Merge pull request #61 from inaka/jfacorro.41.macro.names.rule.bug
ddc84e8 
[#41] Fixed bug in macro_names rule
ferigis added a commit to inaka/elvis_core that referenced this issue Feb 9, 2017
@ferigis
[inaka/elvis#41] no_nested_try_catch rule added
a083332
@ferigis ferigis mentioned this issue Feb 9, 2017
Merged
elbrujohalcon pushed a commit to inaka/elvis_core that referenced this issue Feb 9, 2017
Merge pull request #75 from inaka/ferigis.410.include_rule
2c39a1d 
[inaka/elvis#41] no_nested_try_catch rule added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elbrujohalcon @jfacorro