-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#41] Fixed bug in macro_names rule #61
Conversation
@@ -3,6 +3,8 @@ | |||
-define (bad_name, "(no)"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid macro name bad_name on line 3. Use UPPER_CASE.
@@ -255,7 +255,7 @@ check_no_tabs(Line, Num, _Args) -> | |||
-spec check_macro_names(binary(), integer(), [term()]) -> | |||
no_result | {ok, elvis_result:item()}. | |||
check_macro_names(Line, Num, _Args) -> | |||
{ok, Regex} = re:compile("^ *[-]define *[(]([^,]+)"), | |||
{ok, Regex} = re:compile("^ *[-]define *[(]([^,(]+)"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after "," on line 258
[#41] Fixed bug in macro_names rule
@@ -3,6 +3,8 @@ | |||
-define (bad_name, "(no)"). | |||
-define(GOOD_NAME, "(megusta)"). | |||
-define(wtf_NAME, "(yuno)"). | |||
-define(GOOD_NAME(Arg), "(megusta)"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid macro name GOOD_NAME(Arg) on line 6. Use UPPER_CASE.
No description provided.