Bypass operator_spaces when unable to find node type #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfacorro please review |
jfacorro
added a commit
that referenced
this pull request
Jan 9, 2015
Bypass operator_spaces when unable to find node type
|
I'm reverting this PR because it breaks this test. _Unless = [we, consider]++ [operands, as, well],We must find a way to handle both @andreineculau's scenario and also the currently tested one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elvis reported erroneously that there is a missing space in https://github.com/for-GET/katt/blob/38a71342aa33ce23f01efce8557a2c71b61e37f0/src/katt_util.erl#L329
After investigating, it seems that elvis (or actually katana) is unable to find the node. My guess is that the guard is too naïve
elvis/src/elvis_code.erl
Line 75 in 2ac9651
Regardless of the core reason, if elvis find a possible error, but cannot verify that it is indeed an error (in this case find the node), it's better to keep quiet (no false positives).