Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bypass operator_spaces when unable to find node type" #196

Merged
merged 1 commit into from
Jan 12, 2015
Merged

Revert "Bypass operator_spaces when unable to find node type" #196

merged 1 commit into from
Jan 12, 2015

Conversation

elbrujohalcon
Copy link
Member

Reverts #189

I'm reverting this PR because it breaks this test.
The line (in the code) that goes undetected is this one:

  _Unless = [we, consider]++ [operands, as, well],

We must find a way to handle both @andreineculau's scenario and also the currently tested one.

jfacorro added a commit that referenced this pull request Jan 12, 2015
@jfacorro
Merge pull request #196 from inaka/revert-189-forgiving_operator_spaces
81f146f 
Revert "Bypass operator_spaces when unable to find node type"
@jfacorro jfacorro merged commit 81f146f into master Jan 12, 2015
@jfacorro jfacorro deleted the revert-189-forgiving_operator_spaces branch January 19, 2016 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elbrujohalcon @jfacorro