-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ignoreNullValues for AWS CloudWatch Scaler #5635
base: main
Are you sure you want to change the base?
add ignoreNullValues for AWS CloudWatch Scaler #5635
Conversation
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
13c0fec
to
53ea3fd
Compare
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
495c201
to
8e41311
Compare
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
584eba6
to
b0d4e84
Compare
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
I added end to end tests here for both minMetricValue and errorWhenNullValues to cover off both scenarios. I need to tidy them up a little, which ill do over the next few days. |
53fac56
to
0ef98c5
Compare
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
0ef98c5
to
0b61f97
Compare
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
68a1c71
to
0dc9b77
Compare
...calers/aws/aws_cloudwatch_min_value_null_values/aws_cloudwatch_min_value_null_values_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
.../aws/aws_cloudwatch_ignore_null_values_false/aws_cloudwatch_ignore_null_values_false_test.go
Outdated
Show resolved
Hide resolved
.../aws/aws_cloudwatch_ignore_null_values_false/aws_cloudwatch_ignore_null_values_false_test.go
Outdated
Show resolved
Hide resolved
tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwatch_min_metric_value_test.go
Outdated
Show resolved
Hide resolved
…tricValue Signed-off-by: robpickerill <r.pickerill@gmail.com>
@robpickerill any updates here please? |
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
Good for review, all comments are addressed |
a67d1c0
to
410c10f
Compare
Signed-off-by: robpickerill <r.pickerill@gmail.com>
410c10f
to
9374c26
Compare
tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwatch_min_metric_value_test.go
Outdated
Show resolved
Hide resolved
/run-e2e aws |
…ch_min_metric_value_test.go fix invalid check Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
/run-e2e aws |
/run-e2e aws |
@robpickerill do we have any update on this, please? |
I was discussing with Jorge on slack to get the e2e tests re-ran, as the failures were upstream issues: https://kubernetes.slack.com/archives/C01JGDP8MB8/p1717129850310929?thread_ts=1715943304.582119&cid=C01JGDP8MB8 However, since then the changes for the validation have gone in, so let me fix up the conflicts here over the weekend, and then let's get e2e passing again on this branch |
Thanks! |
Signed-off-by: robpickerill <r.pickerill@gmail.com>
731d45c
to
2e76a9b
Compare
Fixed conflicts, this needs another e2e test run |
/run-e2e aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robpickerill there is also a problem in static checks
Fixed, all tests should pass now. I see e2e didn't run due to Azure cluster scaling actions failing, would it be easier for me to put the e2e tests in a different PR and unblock this PR? The unit tests here cover the error case for the scaler, but I wanted to add e2e to prove the backward compatibility for the change. Let me know what works best for you. |
Signed-off-by: robpickerill <r.pickerill@gmail.com>
48ccb91
to
43a2c3f
Compare
/run-e2e aws |
This PR adds support for erroring the AWS Cloudwatch Scaler when the GetMetricData call returns an empty set of metrics, resulting in no scale-changing behaviour when no custom metrics are available during the Cloudwatch query window.
Checklist
Fixes #5352
Relates to: