Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ignoreNullValues for AWS CloudWatch Scaler #5635

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

add ignoreNullValues for AWS CloudWatch Scaler #5635

wants to merge 29 commits into from

Commits on Mar 28, 2024

  1. add errorWhenMetricValueEmpty 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    53ea3fd View commit details
    Browse the repository at this point in the history

  2. fix golangci-lint 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4174e93 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. improve error message for empty results 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    8e41311 View commit details
    Browse the repository at this point in the history

  2. add error when empty metric values to changelog 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b0d4e84 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. rename errorWhenMetricValuesEmpty -> errorWhenNullValues 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    7a5f617 View commit details
    Browse the repository at this point in the history

  2. use getParameterFromConfigV2 to read config for errorWhenNullValues 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    96a2254 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into cloudwatch-error-when-empty-metrics 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    476b4e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. add e2e for error state for cw, and improve e2e for min values for cw 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0b61f97 View commit details
    Browse the repository at this point in the history

  2. remove erroneous print statement 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c6dc524 View commit details
    Browse the repository at this point in the history

  3. remove unused vars 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0dc9b77 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. rename errorWhenMetricValuesEmpty -> ignoreNullValues 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1f70736 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. move towards shared package for e2e aws 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    185db21 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. minMetricValue optionality based on ignoreNullValues 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    9f5bbf5 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. fail fast 

    Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill @JorTurFer
    robpickerill and JorTurFer committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    97f47a0 View commit details
    Browse the repository at this point in the history

  2. Update tests/scalers/aws/aws_cloudwatch_ignore_null_values_false/aws_… 

    …cloudwatch_ignore_null_values_false_test.go

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill @JorTurFer
    robpickerill and JorTurFer committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9d0ce60 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill @JorTurFer
    robpickerill and JorTurFer committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a8959f2 View commit details
    Browse the repository at this point in the history

  4. fail fast 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    702817f View commit details
    Browse the repository at this point in the history

  5. fix broken new line 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    2862e9c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into cloudwatch-error-when-empty-metrics 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f390bc4 View commit details
    Browse the repository at this point in the history

  7. fix broken new lines 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c684676 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. assert no scaling changes in e2e, and set false for required in minMe… 

    …tricValue

Signed-off-by: robpickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed May 4, 2024
    Configuration menu
    Copy the full SHA
    5aceb72 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Merge branch 'main' into cloudwatch-error-when-empty-metrics 

    Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed May 20, 2024
    Configuration menu
    Copy the full SHA
    96b4097 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. fix ci checks 

    Signed-off-by: robpickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9374c26 View commit details
    Browse the repository at this point in the history

  2. Update tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwat… 

    …ch_min_metric_value_test.go


fix invalid check

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
    @robpickerill @JorTurFer
    robpickerill and JorTurFer committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1898924 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Merge branch 'main' into cloudwatch-error-when-empty-metrics

    @robpickerill
    robpickerill committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a97992b View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge branch 'kedacore:main' into cloudwatch-error-when-empty-metrics

    @robpickerill
    robpickerill committed May 31, 2024
    Configuration menu
    Copy the full SHA
    943f929 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. Merge branch 'main' into cloudwatch-error-when-empty-metrics

    @robpickerill
    robpickerill committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    ddd9f63 View commit details
    Browse the repository at this point in the history

  2. fix merge conflicts 

    Signed-off-by: robpickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    2e76a9b View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. fix e2e package names 

    Signed-off-by: robpickerill <r.pickerill@gmail.com>
    @robpickerill
    robpickerill committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    43a2c3f View commit details
    Browse the repository at this point in the history