Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal QoS Manager #262

Merged
merged 9 commits into from
Jun 28, 2022
Merged

Proposal QoS Manager #262

merged 9 commits into from
Jun 28, 2022

Conversation

stormgbs
Copy link
Member

Ⅰ. Describe what this PR does

Propose QoS Manager for refactoring dynamic plugins in koordlet.

Ⅱ. Does this pull request fix one issue?

fixes #58

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #262 (d3712b7) into main (444d598) will increase coverage by 2.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   60.52%   62.89%   +2.36%     
==========================================
  Files         103      107       +4     
  Lines        9602     9942     +340     
==========================================
+ Hits         5812     6253     +441     
+ Misses       3304     3192     -112     
- Partials      486      497      +11     
Flag Coverage Δ
unittests 62.89% <ø> (+2.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/slo-controller/nodeslo/nodeslo_controller.go 43.33% <0.00%> (-16.53%) ⬇️
.../koordlet/runtimehooks/hooks/groupidentity/rule.go 86.59% <0.00%> (-3.73%) ⬇️
pkg/slo-controller/noderesource/noderesource.go 83.46% <0.00%> (-1.96%) ⬇️
pkg/koordlet/statesinformer/config.go 100.00% <0.00%> (ø)
pkg/koordlet/statesinformer/register.go 70.17% <0.00%> (ø)
...slo-controller/noderesource/resource_calculator.go 100.00% <0.00%> (ø)
pkg/runtime/runtime.go
pkg/runtime/handler/fake_runtime.go
...controller/noderesource/configmap_event_handler.go
pkg/runtime/handler/containerd_runtime.go
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 444d598...d3712b7. Read the comment docs.

docs/proposals/koordlet/20220615-qos-manager.md Outdated Show resolved Hide resolved
docs/proposals/koordlet/20220615-qos-manager.md Outdated Show resolved Hide resolved
docs/proposals/koordlet/20220615-qos-manager.md Outdated Show resolved Hide resolved
docs/proposals/koordlet/20220615-qos-manager.md Outdated Show resolved Hide resolved
docs/proposals/koordlet/20220615-qos-manager.md Outdated Show resolved Hide resolved
Signed-off-by: stormgbs <stormgbs@gmail.com>
Signed-off-by: stormgbs <stormgbs@gmail.com>
@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jun 28, 2022
@hormes
Copy link
Member

hormes commented Jun 28, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c063d0c into koordinator-sh:main Jun 28, 2022
@zwzhang0107 zwzhang0107 mentioned this pull request Nov 10, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] design of qos-plugin-manager
5 participants