Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoS Manager Framework #796

Merged
merged 2 commits into from
Nov 11, 2022
Merged

QoS Manager Framework #796

merged 2 commits into from
Nov 11, 2022

Conversation

stormgbs
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: stormgbs <stormgbs@gmail.com>
Signed-off-by: stormgbs <stormgbs@gmail.com>
@zwzhang0107
Copy link
Contributor

ref #262 #174

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 68.12% // Head: 67.87% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (9a82690) compared to base (10f8e50).
Patch coverage: 40.52% of modified lines in pull request are covered.

❗ Current head 9a82690 differs from pull request most recent head ef0aeee. Consider uploading reports for the commit ef0aeee to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   68.12%   67.87%   -0.26%     
==========================================
  Files         212      215       +3     
  Lines       24115    24305     +190     
==========================================
+ Hits        16429    16497      +68     
- Misses       6551     6666     +115     
- Partials     1135     1142       +7     
Flag Coverage Δ
unittests 67.87% <40.52%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/qosmanager/manager.go 0.00% <0.00%> (ø)
pkg/koordlet/config/config.go 47.27% <19.23%> (-25.15%) ⬇️
.../koordlet/qosmanager/metricsquery/metrics_query.go 57.54% <57.54%> (ø)
pkg/koordlet/qosmanager/config/config.go 100.00% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-5.27%) ⬇️
...eduler/plugins/coscheduling/controller/podgroup.go 72.19% <0.00%> (-1.96%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 39cb1d1 into koordinator-sh:main Nov 11, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants