-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make dev doesn't run npm install on first run #82
Comments
To solve this for Composer's |
Yeah, that's what it looks like, and managed to respond faster then me writing the pull request... |
Do you think checking for an empty directory is the best solution for NPM, or is there a file of some kind that gets written like I don't know the answer... |
I’m not aware of analogue to The down side is you could have an old The other option I considered was using a environment variable flag with services:
# •••
php:
# •••
environment:
INIT: ${INIT:-0}
# ••• Which lets you access it from the container by checking if That approach is quite a bit more complicated but would let you explicitly say when you want to run the installer and when you don’t from the make file. So you could add some more commands to the make file to handle |
…iables override existing injected environment variables ([nystudio107#82](craftcms/craft#82))
Hi! I'm getting the same issue. Vite won't run due to: |
Describe the bug
When working with a project that uses a version controlled
package-lock.json
filemake dev
will not causenpm_install.sh
to runnpm install
because the directorynode_modlues
always exists because it is a volume delegate indocker-compose.yml
.To reproduce
Steps to reproduce the behaviour:
package-lock.json
make dev
Expected behaviour
Vite container runs
npm install
and startsThe text was updated successfully, but these errors were encountered: