Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hashbang /bin/sh #94

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Make hashbang /bin/sh #94

merged 2 commits into from
Jun 27, 2024

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Oct 26, 2023 •
edited
Loading

Fixes #82

@timkelty timkelty mentioned this pull request Oct 26, 2023
Closed
@dGilli
Copy link

dGilli commented Nov 1, 2023

And fixes #90

@khalwat
Copy link
Contributor

khalwat commented Nov 1, 2023

Yeah, I'm aware of the issue, it's because they changed the base image of Alpine to no longer include bash

@timkelty timkelty changed the title Make hashbash /bin/sh Make hashbang /bin/sh Nov 2, 2023
@khalwat khalwat merged commit 879de07 into nystudio107:craft-vite Jun 27, 2024
@khalwat
Copy link
Contributor

khalwat commented Jun 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make dev doesn't run npm install on first run
3 participants
@timkelty @dGilli @khalwat