Use histogram advice in the Micrometer bridge #8334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2023
mateuszrzeszutek
force-pushed
the
micrometer-histogram-advice
branch
from
19d8dea
to
9e0d77e
Compare
This was referenced May 8, 2023
trask
approved these changes
May 8, 2023
...brary/src/main/java/io/opentelemetry/instrumentation/micrometer/v1_5/OpenTelemetryTimer.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
micrometer-histogram-advice
branch
from
4630479
to
249f92c
Compare
laurit
reviewed
May 9, 2023
laurit
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5292
I'm marking this as a draft cause this requires a bump of the SDK version to the latest snapshot -- which, unfortunately, introduces a lot of trouble (including changes related to the logs API). We'll want to rebase this PR and merge it just before the 1.26 release.
cc @jack-berg