Specify ...jvm.gc.duration buckets using advice API #8436
Conversation
.../library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/GarbageCollector.java
Show resolved
Hide resolved
.../library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/GarbageCollector.java
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
gc-duration-advice
branch
from
aa25995
to
02c8d9e
Compare
| } | ||
| ((ExtendedDoubleHistogramBuilder) builder) | ||
| .setAdvice(advice -> advice.setExplicitBucketBoundaries(emptyList())); |
There was a problem hiding this comment.
Hi @mateuszrzeszutek, sorry for tagging in an old PR, but I am just wondering the reason for making explicitBucketBoundaries as an empty list?
Before version 1.26.0 I am pretty sure it used to have the explicitBucketBoundaries.
There was a problem hiding this comment.
Hey @kes2464 ,
We've had many discussions on what the buckets for the gc metrics should be; and for a long while we were of the opinion that we should not provide any, and instead allow the users to set the buckets they want via the SDK Views. The current implementation reflects that.
We'll likely add some buckets when the JVM metrics become stable in the 2.0 version, see open-telemetry/semantic-conventions#317
There was a problem hiding this comment.
Thanks for the detailed explanation @mateuszrzeszutek, I think it makes sense for GC metrics as it may vary depending on the apps and so on. For me, as long as they can be created it's fine, and adding a new View worked perfectly.
This needs to be merged after #8334