Change aws-sdk client decorators to tracers #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
heyams
commented
Aug 7, 2020
...in/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/AWSHttpClientInstrumentation.java
Show resolved
Hide resolved
heyams
commented
Aug 7, 2020
...in/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/AWSHttpClientInstrumentation.java
Show resolved
Hide resolved
...sdk-1.11/src/main/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/OnErrorTracer.java
Show resolved
Hide resolved
heyams
commented
Aug 7, 2020
...ap/src/main/java/io/opentelemetry/auto/bootstrap/instrumentation/decorator/ClientTracer.java
Outdated
Show resolved
Hide resolved
heyams
commented
Aug 7, 2020
...rc/main/java/io/opentelemetry/auto/bootstrap/instrumentation/decorator/HttpClientTracer.java
Outdated
Show resolved
Hide resolved
heyams
force-pushed
the
heya/http-client-tracers-2
branch
from
c03f043
to
6365c0e
Compare
heyams
changed the title
heyams
requested review from
anuraaga,
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
trask
reviewed
Aug 7, 2020
...in/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/AWSHttpClientInstrumentation.java
Show resolved
Hide resolved
.../src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/TracingExecutionInterceptor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/TracingExecutionInterceptor.java
Outdated
Show resolved
Hide resolved
...sdk-1.11/src/main/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/OnErrorTracer.java
Show resolved
Hide resolved
...rc/main/java/io/opentelemetry/auto/bootstrap/instrumentation/decorator/HttpClientTracer.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 8, 2020
...ap/src/main/java/io/opentelemetry/auto/bootstrap/instrumentation/decorator/ClientTracer.java
Outdated
Show resolved
Hide resolved
...k/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdk.java
Show resolved
Hide resolved
...ap/src/main/java/io/opentelemetry/auto/bootstrap/instrumentation/decorator/ClientTracer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/TracingRequestHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/TracingRequestHandler.java
Outdated
Show resolved
Hide resolved
...2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkClientTracer.java
Outdated
Show resolved
Hide resolved
...2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkClientTracer.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Aug 11, 2020
...in/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/AWSHttpClientInstrumentation.java
Show resolved
Hide resolved
...in/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/AWSHttpClientInstrumentation.java
Show resolved
Hide resolved
iNikem
reviewed
Aug 11, 2020
....11/src/main/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/AwsSdkClientTracer.java
Show resolved
Hide resolved
.../src/main/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/TracingRequestHandler.java
Show resolved
Hide resolved
...2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkClientTracer.java
Show resolved
Hide resolved
.../src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/TracingExecutionInterceptor.java
Outdated
Show resolved
Hide resolved
anuraaga
approved these changes
Aug 12, 2020
mabdinur
pushed a commit
to mabdinur/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #828
Continuation of #893
This PR focuses on aws-sdk 1.11 and 2.2
Aws-sdk tracers are structured differently. Need some feedback on how to apply the same pattern like other tracers.