Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the rest of decorators to tracers #922

Merged
merged 47 commits into from
Aug 13, 2020
Merged

Change the rest of decorators to tracers #922

merged 47 commits into from
Aug 13, 2020

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Aug 7, 2020

Continuation of #918
Fix #828

@heyams
Copy link
Contributor Author

heyams commented Aug 7, 2020 •
edited
Loading

Task :auto-bootstrap:spotbugsMain
H D UC: Method io.opentelemetry.auto.bootstrap.instrumentation.decorator.BaseTracer.setPeer(Span, String, String) seems to be useless At BaseTracer.java:[line 165]
H V MS: io.opentelemetry.auto.bootstrap.instrumentation.java.concurrent.State.FACTORY isn't final but should be At State.java:[line 29]
H I Dm: Found reliance on default encoding in io.opentelemetry.auto.config.Config.loadConfigurationFile(): new java.io.FileReader(File) At Config.java:[line 505]
SpotBugs reported failures
org.gradle.api.GradleException: Verification failed: SpotBugs violation found: 3

Need help with fixing these SpotBugs violations.

@heyams heyams mentioned this pull request Aug 7, 2020
Merged
@heyams heyams marked this pull request as ready for review August 8, 2020 00:47
trask
trask reviewed Aug 11, 2020
View reviewed changes
...rumentation/spring/autoconfigure/httpclients/resttemplate/RestTemplateBeanPostProcessor.java Outdated Show resolved Hide resolved
...lemetry/auto/instrumentation/apachehttpasyncclient/ApacheHttpAsyncClientInstrumentation.java Show resolved Hide resolved
...lemetry/auto/instrumentation/apachehttpasyncclient/ApacheHttpAsyncClientInstrumentation.java Show resolved Hide resolved
...io/opentelemetry/auto/instrumentation/apachehttpasyncclient/ApacheHttpAsyncClientTracer.java Show resolved Hide resolved
...java/io/opentelemetry/auto/instrumentation/apachehttpclient/v4_0/ApacheHttpClientHelper.java Outdated Show resolved Hide resolved
...java/io/opentelemetry/auto/instrumentation/apachehttpclient/v4_0/ApacheHttpClientTracer.java Outdated Show resolved Hide resolved
...ava/io/opentelemetry/auto/instrumentation/jaxrsclient/v1_1/JaxRsClientV1Instrumentation.java Outdated Show resolved Hide resolved
...main/java/io/opentelemetry/auto/instrumentation/kubernetesclient/KubernetesClientTracer.java Outdated Show resolved Hide resolved
trask
trask approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @heyams, this looks great!

...va/io/opentelemetry/instrumentation/spring/webflux/client/SpringWebfluxHttpClientTracer.java Show resolved Hide resolved
iNikem
iNikem suggested changes Aug 13, 2020
View reviewed changes
...va/io/opentelemetry/instrumentation/spring/webflux/client/SpringWebfluxHttpClientTracer.java Show resolved Hide resolved
...java/io/opentelemetry/auto/instrumentation/apachehttpclient/v4_0/ApacheHttpClientHelper.java Show resolved Hide resolved
...java/io/opentelemetry/auto/instrumentation/apachehttpclient/v4_0/ApacheHttpClientTracer.java Outdated Show resolved Hide resolved
....11/src/main/java/io/opentelemetry/auto/instrumentation/awssdk/v1_11/AwsSdkClientTracer.java Show resolved Hide resolved
.../src/main/java/io/opentelemetry/auto/instrumentation/jaxrsclient/v2_0/JaxRsClientTracer.java Show resolved Hide resolved
...ava/io/opentelemetry/auto/instrumentation/jaxrsclient/v1_1/JaxRsClientV1Instrumentation.java Outdated Show resolved Hide resolved
...main/java/io/opentelemetry/auto/instrumentation/kubernetesclient/KubernetesClientTracer.java Show resolved Hide resolved
@trask trask mentioned this pull request Aug 13, 2020
Closed
@trask trask merged commit 09c597e into open-telemetry:master Aug 13, 2020
@trask
Copy link
Member

trask commented Aug 13, 2020

🥳

@heyams heyams deleted the heya/http-client-tracers-3 branch August 14, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@anuraaga anuraaga anuraaga approved these changes

@iNikem iNikem iNikem approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create HttpClientTracer and migrate from HttpClientDecorator
4 participants
@heyams @trask @anuraaga @iNikem