[target-allocator] use json iterator to marshal in server #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristinapathak
force-pushed
the
json-iterator
branch
from
624d0ff
to
bc47716
Compare
jaronoff97
reviewed
Mar 19, 2023
cmd/otel-allocator/server/server.go
Outdated
Comment on lines
188
to
190
| w.Header().Set("Content-Type", "application/json") | ||
| err := s.jsonMarshaller.NewEncoder(w).Encode(data) | ||
| if err != nil { |
There was a problem hiding this comment.
do our tests already cover this case? i.e. is this change just going to work with what we do in the collector? using specifically the yaml unmarshal function?
There was a problem hiding this comment.
That yaml unmarshal function is for a response from the scrape config handler, which doesn't use the jsonHandler function. Here is the marshaling logic for the scrape config endpoint.
The jsonHandler() function is used for the job and targets handlers, both of which have test cases which ensure that this marshaling is still compatible with json.Unmarshal():
kristinapathak
force-pushed
the
json-iterator
branch
from
bc47716
to
c6a1236
Compare
|
Latest benchmarks |
jaronoff97
approved these changes
Mar 20, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1336
This time, server functionality is covered by unit tests. Below are the results of the benchmarks, showing using the standard json library (std) vs jsoniter.
test_results.txt