[target-allocator] Remove json conversion from /scrape_configs #1411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1404
This change is breaking in that the scrape configs endpoint will now response with YAML instead of JSON. However, the prometheus receiver which sends requests to
/scrape_configs
is currently usingyam.Unmarshal
: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/72d590e8e76a18bbec6d4ce8b6200520c5e94732/receiver/prometheusreceiver/metrics_receiver.go#L205-L233This doesn't give us a large performance gain (compared to using jsoniter), but it is noticeable in benchmarks:
scrapeconfig_bench_results.txt