adds vpa daemonset handling #1779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
reviewed
Jun 1, 2023
There was a problem hiding this comment.
@KitSutliff were you able to do any manual testing and observe the vertical scaling working as expected?
|
Ah no. haven't reproduced it on a working cluster, developing an end-to-end based on the hpa tests |
…r is enabled (open-telemetry#1712) * Code fix for issues open-telemetry#1623, open-telemetry#1622, open-telemetry#958 * updated the PR with an alternative logic to fi the relabel config issue * fixed codelint issues * reverted the logic to update scrape_configs * fixed unit test case failures * fixed code lint issues * changes to replace_config to handle unamrshalling issue when tarallocatorewrite flag is enabled * fixed unit test case failure * updated e2e test to cover labelkeep usecase * updated unit test to escape $ signs * updated unit test to cover missing and invalig configs * resolved merge conflicts * updated tests, refactored logic based on the new commits * uncommented labeldrop e2e test * added back target allocator attribute * comment for unescaping TA config * updated the README document to reflect the traslations * updated the README document to reflect the traslations * updated the TA config section in the README document * addressed the review comment on README doc --------- Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
* Bump python to 1.18.0/0.39b0 * changelog --------- Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
* release the operator * update changelog and versions * remove last compat * Fix changelog * more chlog
* Bump all the deps * linter
|
@KitSutliff looks like a bad rebase, you may want to reattempt your rebase on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooled around with this and think I've got a fix. Did not implement sidecar for now. Any thoughts?
fixes #1667