Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inf2 package dependency version conflicts #2887

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

namannandan
Copy link
Collaborator

@namannandan namannandan commented Jan 3, 2024

Description

Recent Inf2 benchmark runs have been failing due to conflicting package versions as follows:

ERROR: Cannot install -r requirements/torch_neuronx_linux.txt (line 4), -r requirements/torch_neuronx_linux.txt (line 5), -r requirements/torch_neuronx_linux.txt (line 6), -r requirements/torch_neuronx_linux.txt (line 7) and torch==1.13.1+cpu because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested torch==1.13.1+cpu
    torchvision 0.14.1+cpu depends on torch==1.13.1
    torchtext 0.14.1 depends on torch==1.13.1
    torchaudio 0.13.1+cpu depends on torch==1.13.1
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
    torchdata 0.7.0 depends on torch==2.1.0
ERROR: Cannot install -r requirements/neuronx.txt (line 4) and protobuf==4.25.1 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested protobuf==4.25.1
    grpcio-tools 1.48.2 depends on protobuf<4.0dev and >=3.12.0

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

@namannandan namannandan changed the title Fix Inf2 package dependency versions Fix Inf2 package dependency version conflicts Jan 3, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation to remove the dependencies altogether rather than handle the version dependency conflict? Also, the conflict seems to exist for protobuf and grpcio-tools. Why are we removing numpy as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove numpy and protobuf because neuronx-cc will setup the required supported version of numpy and torch-neuronx will do the same for protobuf. This way, we don't have to hardcode individual package versions. Also, grpcio-tools is not a dependency for neuronx-cc, torch-neuronx or transformers-neuronx so I've removed that as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@namannandan namannandan added this pull request to the merge queue Jan 3, 2024
Merged via the queue into master with commit 2eae8e5 Jan 3, 2024
13 checks passed
@namannandan namannandan deleted the inf2_dependency_fix branch January 3, 2024 22:29
@chauhang chauhang added this to the v0.10.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants