Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :rails71 shared context #1134

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Add :rails71 shared context #1134

merged 1 commit into from
Sep 30, 2023

Conversation

sambostock
Copy link
Contributor

This adds a shared context for the upcoming Rails 7.1, whose release candidate was released yesterday. As a release candidate indicates APIs are likely stable, we can begin writing/updating cops for it.

This commit was extracted from #906, and could be used in #894.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit c111a29 into rubocop:master Sep 30, 2023
10 checks passed
@sambostock sambostock deleted the rails-71-ctx branch September 30, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants