Support local as an environment for Rails/UnknownEnv from Rails 7.1 onward.

[ghiculescu]

Fixes #893

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
• If this is a new cop, consider making a corresponding update to the Rails Style Guide.

[sambostock]

I missed this PR and added support for local as part #906 as well. I think this approach is better, although it may make sense to cherry pick my commit introducing a :rails71 shared context (or I can open a separate PR for that, but it seems small) rather than a custom config, especially given the rest of this config is just the defaults.

[sambostock]

I've extracted the shared context into its own PR in #1134.

[sambostock]

Does this warrant updating the cop's VersionChanged config?

[ghiculescu]

Probably? I'm not very familiar with how this works. Do I add the next version number or is there some other workflow for this?

[ghiculescu]

@koic do you have any opinions on this PR vs #906 ?

[koic]

Rails 7.1 is a development version yet. So, the new feature for Rails 7.1 merge is pending until at least a beta, preferably a release candidate is shipped.
#906 (comment)

[ghiculescu]

Got it. Thanks.

[mjankowski]

Rails 7.1.0.beta1 is out, and this feature (adding local? method) is included.

[koic]

The release of RC is probably not far away. In principle, API will be stable once it becomes RC, so let's wait for a while.

[mjankowski]

The release of RC is probably not far away. In principle, API will be stable once it becomes RC, so let's wait for a while.

Makes sense!

Also: 7.1.0.rc1 is out now

[sambostock]

Now that #1134 has been merged, I think this could be changed to use the shared context and cop_config defined above. We also don't need to repeat "Rails 7.1" in the spec name, as it is already in the context name.

Suggested change

	context 'Rails 7.1' do
	let(:config) do
	RuboCop::Config.new(
	{
	'AllCops' => {
	'TargetRailsVersion' => '7.1'
	},
	'Rails/UnknownEnv' => {
	'Environments' => %w[
	development
	production
	test
	]
	}
	}
	)
	end
	it 'accepts local as an environment name on Rails 7.1' do
	context 'in Rails 7.1 onwards', :rails71 do
	it 'accepts local as an environment name' do

[koic]

@ghiculescu ping.

[ghiculescu]

Thanks for the PR. I'm not going to be able to work on this for a little while, @sambostock or @koic are you interested in taking it over? Happy to close this PR and move to a new one if you like.

[koic]

Well, adjustments to the test code can be done separately. I'm going to merge this PR. Thank you @ghiculescu!